fix selectAll showing when limit #7245
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfilben
reviewed
May 31, 2024
There was a problem hiding this comment.
In SelectedValuesDisabled can we change the if statement on line 54 to
if (
value.length === disabledSelected ||
selectedInSearch().length === disabledSelected
)
This prevents an issue where the values selected after searching are disabled and the button shows 'clear all' even though nothing can be cleared because they are all disabled
| @@ -68,7 68,7 @@ const SelectionSummary = ({ | |||
| value?.length === 0 || | |||
| selectedValuesDisabled() || | |||
| !value || | |||
| selectedInSearch().length === 0 | |||
| (!limit && selectedInSearch().length === 0) | |||
There was a problem hiding this comment.
Do we still need this change? I didn't see a difference in behavior with vs without it
There was a problem hiding this comment.
good catch yes we dont need
added 2 commits
May 31, 2024 10:05
taysea
reviewed
Jun 3, 2024
britt6612
requested review from
taysea and
jcfilben
and removed request for
taysea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes
selectAllbeing shown when there is a limit.Where should the reviewer start?
SelectionSummary
What testing has been done on this PR?
storybook & jest test
How should this be manually tested?
Create a SelectMultiple component where limit property is provided
Don't select anything. Search something that exists, the Select All does not get displayed.
Clear the search and select any option from dropdown.
Search with a keyword that does not match the selected value but matches other values in the list.
Select All option gets displayed.
Do Jest tests follow these best practices?
screenis used for querying.asFragment()is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
closes #7219
Screenshots (if appropriate)
Do the grommet docs need to be updated?
no
Should this PR be mentioned in the release notes?
yes
Is this change backwards compatible or is it a breaking change?
backwards compatible