more of a question.. should the user be put back to page one? after re-selecting items per page

more of a question.. should the user be put back to page one? after re-selecting items per page

I put them on the last page because then they would be closer to the data that they were previously viewing before changing the step

more of a question.. should the user be put back to page one? after re-selecting items per page

I put them on the last page because then they would be closer to the data that they were previously viewing before changing the step

gotcha just wanted to make sure that was the correct pattern!

To just speak out loud, is it correct to say our logic is "as step changes, we keep the previously active page active. For example, if user was on page 5 and they change from step of 10 to 25, we'll stay on step 5. In cases where the page no longer exists because there are less total pages, we'll fallback to the last page"?

I'm trying to figure out what I'd expect in a scenario like this where I was on page 14, then increased the step, and then was on the last page of data.

@halocline any thoughts on behavior?

To just speak out loud, is it correct to say our logic is "as step changes, we keep the previously active page active. For example, if user was on page 5 and they change from step of 10 to 25, we'll stay on step 5. In cases where the page no longer exists because there are less total pages, we'll fallback to the last page"?

I'm trying to figure out what I'd expect in a scenario like this where I was on page 14, then increased the step, and then was on the last page of data.

@halocline any thoughts on behavior?

I agree that we should pause and think through this a bit further. The page 14 to last page scenario isn't right - because last page is much further away.

We are either "smart" and do something like ensure the index of the first item in the current page is in the resulting subset in the next page.

Or, always go back to page 1.

We also need to consider the controlled scenario as well.

I agree that we should pause and think through this a bit further. The page 14 to last page scenario isn't right - because last page is much further away.

I'm confused by the statement 'last page is much further away', if we have a scenario where we are on page 14 and the step changes in such a way that page 14 no longer exists and we are moved to the last page then the data on the last page will include data from page 14

I agree that we should pause and think through this a bit further. The page 14 to last page scenario isn't right - because last page is much further away.

I'm confused by the statement 'last page is much further away', if we have a scenario where we are on page 14 and the step changes in such a way that page 14 no longer exists and we are moved to the last page then the data on the last page will include data from page 14

I think point is that isn't necessarily true. You probably could do the math to figure out what page in the new step size contains the top item from the previous current page. But we do need to think a little more about the various cases and if we're screwing up the controlled situations (ie. not letting the caller control where it ends up when step changes.)

I think point is that isn't necessarily true. You probably could do the math to figure out what page in the new step size contains the top item from the previous current page. But we do need to think a little more about the various cases and if we're screwing up the controlled situations (ie. not letting the caller control where it ends up when step changes.)

Ah okay I was thinking of page 14 as the last page, but if page 14 is a middle page I see what you are saying.

Slow brain haha sorry, should we just default to going back to the first page? Unless Pagination is in a controlled state then we wouldn't do anything

Writing out logic for going back to Page 1

If the current page no longer exists
  If `pageProp` and `onChange` are defined
    Do nothing, Pagination is in a controlled state
  Else set page to the first page

If a different behavior is desired then it can be achieved through a controlled version of Pagination

Writing out logic for keeping previously visible data visible

If the current page no longer exists or the data that was visible has moved to a different page
  Determine what was the "first" record that was previously visible
  Set page to the page that now contains record
  If `pageProp` and `onChange` are defined
    Do nothing, Pagination is in a controlled state

If a different behavior is desired then it can be achieved through a controlled version of Pagination