Update helm chart for newer grafana enable externalServiceAccounts #4876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Closed
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
had a problem deploying
to
github-pages
GitHub Actions
Failure
mderynck
added
release:ignore
mderynck
had a problem deploying
to
github-pages
GitHub Actions
Error
mderynck
had a problem deploying
to
github-pages
GitHub Actions
Error
mderynck
had a problem deploying
to
github-pages
GitHub Actions
Error
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
matiasb
approved these changes
Sep 5, 2024
README.md
Outdated
| 5. Go to [OnCall Plugin Configuration](http://localhost:3000/plugins/grafana-oncall-app), using log in credentials | ||
| as defined above: `admin`/`admin` (or find OnCall plugin in configuration->plugins) and connect OnCall _plugin_ | ||
| with OnCall _backend_: | ||
| 5. Provision the plugin (If you run Grafana outside the included docker files, install the plugin before these steps): |
There was a problem hiding this comment.
Maybe some mention about using the right Grafana admin credentials? (just in case not using default, similar as stated in the Troubleshooting section below)
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
had a problem deploying
to
github-pages
GitHub Actions
Error
mderynck
had a problem deploying
to
github-pages
GitHub Actions
Error
mderynck
had a problem deploying
to
github-pages
GitHub Actions
Error
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Comment on lines
5
to
6
| base_url: example.com | ||
| base_url_protocol: https | ||
| base_url_protocol: http |
There was a problem hiding this comment.
base_url_protocol isn't the change from https to http a breaking change and maybe a security downgrade?
There was a problem hiding this comment.
Shouldn't this helm-testing-grafana-plugin-provisioning have for instance apps.0.jsonData.onCallApiUrl, apps.0.jsonData.orgId, apps.0.disabled, ... all templated?
*-testing-* shouldn't be the name of something used in prod, right?
Shouldn't this configmap be toggleable?
Comment on lines
649
to
656
| extraVolumes: | ||
| - name: provisioning | ||
| configMap: | ||
| name: helm-testing-grafana-plugin-provisioning | ||
| extraVolumeMounts: | ||
| - name: provisioning | ||
| mountPath: /etc/grafana/provisioning/plugins/grafana-oncall-app-provisioning.yaml | ||
| subPath: grafana-oncall-app-provisioning.yaml |
There was a problem hiding this comment.
The plugin provisioning logic should be done in the templates. If someone overrides extraVolumes or extraVolumeMounts this won't work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Updates the helm chart and docker compose files with the required changes to support the plugin initialization changes. Updated instructions on the README.md show how to setup & intialize OnCall without needing to go to the configuration page, this is currently the preferred method.
Which issue(s) this PR closes
Related to [issue link here]
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.