helm: allow configuration of smtp credentials via existing secret #4643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
joeyorlando
approved these changes
Jul 24, 2024
joeyorlando
changed the title
joeyorlando
added
the
release:patch
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
github-actions
bot
added
the
pr:stale
|
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds three keys to the helm chart values:
smtp.existingSecret,smtp.usernameKeyandsmtp.passwordKeywhich allows for secure configuration of the smtp integration.We noticed this, as we wanted to set all integration keys through secrets. We tried to bypass the Helm chart behavior by defining environment variables through
envdirectly. However as we use Argo CD which has to diff the current state with the desired state, it caused issues. Diffing requires environment key names to be unique, in order to properly create a diff, unfortunately. Instead of just not setting any of the environment keys that the chart is currently setting, I opted to just allow setting the smtp credentials through an existing secret, which is how the other integrations handle it too.I also added the usernameKey to the secret, as we use Postmark for SMTP where the "password" is also the username, so it needs to be in a secret too.
Which issue(s) this PR closes
There is no related existing issue yet.
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.