Fix Telegram ratelimit on live setting change #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadimkerr
added
the
pr:no public docs
vadimkerr
commented
Jun 5, 2023
| """ | ||
| if self.name not in self.AVAILABLE_NAMES: | ||
| raise ValueError( | ||
| f"Setting with name '{self.name}' is not in list of available names {self.AVAILABLE_NAMES}" | ||
| ) | ||
|
|
||
| self.error = LiveSettingValidator(live_setting=self).get_error() |
There was a problem hiding this comment.
Moving validation to LiveSetting.validate_settings to avoid multiple validation calls.
3 tasks
|
Great! That's really fixes an issue. |
mderynck
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes #1103, inspired by #1934.
Makes sure that:
LiveSettings.validate_settingsis only called once per update request and not called for any individual LiveSetting instance save.telegram.Bot.set_webhookis only called once per request when changingTELEGRAM_WEBHOOK_HOST.Which issue(s) this PR fixes
#1103
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)