Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add prettier to build, and run against exsiting markdown #171

Merged
merged 12 commits into from
Aug 30, 2021
Merged

add prettier to build, and run against exsiting markdown #171

merged 12 commits into from
Aug 30, 2021

Conversation

trevorwhitney
Copy link
Contributor

Signed-off-by: Trevor Whitney [email protected]

What this PR does:
Adds prettier to the linting step of the build, as well as running prettier against existing markdown files.

Which issue(s) this PR fixes:
#170

@trevorwhitney
Copy link
Contributor Author

trevorwhitney commented Aug 24, 2021 •
edited
Loading

Having trouble running make push-multiarch-build-image to update the build image to get the linting step to pass, any thoughts?

Needed to enable multiarch support for docker buildx by running: docker run --privileged --rm tonistiigi/binfmt --install all
https://docs.docker.com/buildx/working-with-buildx/#build-multi-platform-images

treid314
treid314 approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@treid314 treid314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

pstibrany
pstibrany reviewed Aug 26, 2021
View reviewed changes
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. I think there are few bugs to fix before we can merge.

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
.github/workflows/test-build-deploy.yml Show resolved Hide resolved
docs/operations/requests-mirroring-to-secondary-cluster.md Outdated Show resolved Hide resolved
docs/proposals/shuffle-sharding-and-zone-awareness.md Outdated Show resolved Hide resolved
docs/proposals/shuffle-sharding-on-the-read-path.md Show resolved Hide resolved
@trevorwhitney
bring over latest changelog
55dc5d5 
Signed-off-by: Trevor Whitney <[email protected]>
@trevorwhitney
add one more embedmd ignore
08cbe96 
Signed-off-by: Trevor Whitney <[email protected]>
@trevorwhitney
Copy link
Contributor Author

@pracucci and @pstibrany thanks for taking a look and finding those bugs. I've fixed them and ignored the changelog for now.

@pstibrany pstibrany mentioned this pull request Aug 30, 2021
Closed
pstibrany
pstibrany approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pstibrany pstibrany enabled auto-merge (squash) August 30, 2021 12:43
@pstibrany pstibrany merged commit 728fd4e into main Aug 30, 2021
@pstibrany pstibrany deleted the add-prettier branch August 30, 2021 12:57
@colega colega mentioned this pull request Dec 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pracucci pracucci pracucci left review comments

@johannaratliff johannaratliff johannaratliff approved these changes

@pstibrany pstibrany pstibrany approved these changes

@treid314 treid314 treid314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@trevorwhitney @treid314 @pstibrany @pracucci @johannaratliff