Add babel plugin to workaround bug in @babel/preset-env #45664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashharrison90
added
type/bug
type/chore
backport v8.4.x
ashharrison90
requested review from
zoltanbedi
and removed request for
a team
Clarity-89
approved these changes
Feb 21, 2022
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-45664-to-v8.4.x origin/v8.4.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 05f68c391c67790cbf8c81c4ac295b12c808d310
# Push it to GitHub
git push --set-upstream origin backport-45664-to-v8.4.x
git switch main
# Remove the local backport branch
git branch -D backport-45664-to-v8.4.xThen, create a pull request where the |
ashharrison90
added a commit
that referenced
this pull request
Feb 21, 2022
(cherry picked from commit 05f68c3)
ashharrison90
added a commit
that referenced
this pull request
Feb 21, 2022
It's a JSON5 file (as documented at https://babeljs.io/docs/en/config-files#supported-file-extensions), so it's safe to use comments there. |
alexweav
pushed a commit
that referenced
this pull request
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
@babel/preset-envto a newer patch version@babel/plugin-proposal-class-propertiesto work around the problem until a fix is released in@babel/preset-envWhich issue(s) this PR fixes:
Fixes #45624
Special notes for your reviewer:
one thing that confuses me a little is that you can apparently add comments to the
babel.config.json? i guess it's not real json then, or it gets stripped out later 😕