Match query-frontend/query-scheduler/querier custom deployments by default #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fault Signed-off-by: Marco Pracucci <[email protected]>
pstibrany
approved these changes
Aug 24, 2021
1 task
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…om-deployment-read-path Match query-frontend/query-scheduler/querier custom deployments by default
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
We have an use case where a in a namespace we have both standards and custom deployments of
query-frontend,query-schedulerandquerier. Similarly to what we've already done for ingesters in the past, we would like to change the default regexs to match<name>.*for these additional services too.Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]