Force parallel configuration of all projects before model building #30226
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
6hundreds
force-pushed
the
6hundreds/30206/parallel-configuration-for-model-building
branch
from
61bf38e
to
de723b1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
6hundreds
force-pushed
the
6hundreds/30206/parallel-configuration-for-model-building
branch
from
93a2499
to
18a4cb6
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
6hundreds
force-pushed
the
6hundreds/30206/parallel-configuration-for-model-building
branch
from
ac2933d
to
9333e47
Compare
|
@bot-gradle test this without pts on linux |
|
I've triggered the following builds with parameters: |
6hundreds
force-pushed
the
6hundreds/30206/parallel-configuration-for-model-building
branch
from
9333e47
to
2523dd6
Compare
6hundreds
force-pushed
the
6hundreds/30206/parallel-configuration-for-model-building
branch
from
2523dd6
to
433ce83
Compare
|
@bot-gradle test this without pts on linux |
|
I've triggered the following builds with parameters: |
| // TODO: isolated expected behaviour for parallel sync | ||
| // server.expect("configure-root") | ||
| // server.expectConcurrent("configure-a", "configure-b") | ||
| server.expectConcurrent("configure-a", "configure-b") |
There was a problem hiding this comment.
This test actually works like this even on master without changes in this PR. I am able to reproduce it locally. That is, projects a and b are configured concurrently.
The reason for this is related to BuildType.TASKS not meaning "only run tasks, no models are built". Instead it means "tasks are requested, but models might as well". Another part of the story is that any IDE sync (IJ 2024.2 and IJ 2024.2.1) is identified as BuildType.TASKS even if no tasks are involved. Instead, I observe a request for "default tasks".
| @Override | ||
| public void prepare(ProjectState projectState) { | ||
| if (buildModelParameters.isIsolatedProjects()) { | ||
| buildLifecycleController.configureProjects(); |
There was a problem hiding this comment.
💭 Calling this method here is actually redundant, because it is already called unconditionally on that model-building code path here.
First via this call:
And then via here:
|
FYI, experimenting with this further in |
Fixes #30206