Remove unused code and add more specific exemptions #30116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donat
approved these changes
Aug 8, 2024
| @@ -30,7 30,7 @@ class DiagnosticToProblemListenerTest extends Specification { | |||
| 1 * additionalData(org.gradle.api.problems.internal.GeneralDataSpec, _) | |||
| } | |||
|
|
|||
| def diagnosticToProblemListener = new DiagnosticToProblemListener(null, null) | |||
| def diagnosticToProblemListener = new DiagnosticToProblemListener(null, null as Context) | |||
There was a problem hiding this comment.
🤔 Since we have only one constructor now, we probably don't need to cast on the second parameter.
reinsch82
force-pushed
the
reinhold/problems/remove-unused-code
branch
from
7151dde
to
a9b5cae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/gradle/bt-ide-experience/issues/11
Reviewing cheatsheet
Before merging the PR, comments starting with