Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Groovy DSL = for ConfigurableFileCollection changes state of Configuration #30273

Open
asodja opened this issue Aug 22, 2024 · 1 comment
Open

Groovy DSL = for ConfigurableFileCollection changes state of Configuration #30273

asodja opened this issue Aug 22, 2024 · 1 comment
Labels
a:bug in:provider-api property lazy provider MapProperty ListProperty DirectoryProperty p:lazy-migration Issues covered by migration to an all-lazy API

Comments

@asodja
Copy link
Member

asodja commented Aug 22, 2024

When using = in Groovy DSL, Configuration is changed from "UNRESOLVED" to "RESOLVED" even though it shouldn't be.

That is probably a consequence of this code:

gradle/platforms/core-configuration/file-collections/src/main/java/org/gradle/api/internal/file/collections/DefaultConfigurableFileCollection.java

Lines 193 to 218 in 99560e1

fileCollection.visitStructure(new FileCollectionStructureVisitor() {
@Override
public boolean startVisit(FileCollectionInternal.Source source, FileCollectionInternal fileCollection) {
if (DefaultConfigurableFileCollection.this == fileCollection) {
throw new UnsupportedOperationException("Self-referencing ConfigurableFileCollections are not supported. Use the from() method to add to a ConfigurableFileCollection.");
}
return true;
}
@Override
public VisitType prepareForVisit(Source source) {
return VisitType.NoContents;
}
@Override
public void visitCollection(Source source, Iterable<File> contents) {
}
@Override
public void visitFileTree(File root, PatternSet patterns, FileTreeInternal fileTree) {
}
@Override
public void visitFileTreeBackedByFile(File file, FileTreeInternal fileTree, FileSystemMirroringFileTree sourceTree) {
}
});

We should probably fix that.
@asodja asodja added a:bug in:provider-api property lazy provider MapProperty ListProperty DirectoryProperty p:lazy-migration Issues covered by migration to an all-lazy API labels Aug 22, 2024
@asodja asodja changed the title Groovy DSL = for ConfigurableFileCollection changes states of Configuration Groovy DSL = for ConfigurableFileCollection changes state of Configuration Aug 22, 2024
asodja added a commit that referenced this issue Aug 22, 2024
@asodja
Upgrade Groovydoc to use lazy properties
b06304d 
Except for classpath due to issue #30273.
@asodja asodja mentioned this issue Aug 22, 2024
Merged
asodja added a commit that referenced this issue Aug 22, 2024
@asodja
Upgrade Groovydoc to use lazy properties
2dd77bd 
Except for classpath due to issue #30273.
asodja added a commit that referenced this issue Aug 22, 2024
@asodja
Upgrade Groovydoc to use lazy properties
7651df7 
Except for classpath due to issue #30273.
@asodja asodja mentioned this issue Aug 22, 2024
Open
asodja added a commit that referenced this issue Aug 26, 2024
@asodja
Upgrade Groovydoc to use lazy properties
0777a04 
Except for classpath due to issue #30273.
@asodja
Copy link
Member Author

asodja commented Aug 26, 2024 •
edited
Loading

Tests:

gradle/platforms/jvm/plugins-groovy/src/integTest/groovy/org/gradle/groovy/GroovyBasePluginIntegrationTest.groovy

Lines 62 to 98 in bf0b3f6

def "only resolves source class path feeding into inferred Groovy class path if/when the latter is actually used (but not during autowiring)"() {
file("build.gradle") << """
plugins {
id("groovy-base")
}
sourceSets {
custom
}
${mavenCentralRepository()}
dependencies {
customImplementation "org.codehaus.groovy:groovy-all:2.4.10"
}
task groovydoc(type: Groovydoc) {
classpath = sourceSets.custom.runtimeClasspath
}
task verify {
def customCompileClasspathState = provider {
configurations.customCompileClasspath.state.toString()
}
def customRuntimeClasspathState = provider {
configurations.customRuntimeClasspath.state.toString()
}
doLast {
assert customCompileClasspathState.get() == "UNRESOLVED"
assert customRuntimeClasspathState.get() == "UNRESOLVED"
}
}
"""
expect:
succeeds("verify")
}

gradle/platforms/jvm/scala/src/integTest/groovy/org/gradle/scala/ScalaBasePluginIntegrationTest.groovy

Lines 65 to 95 in e33d781

def "only resolves source class path feeding into inferred Scala class path if/when the latter is actually used (but not during autowiring)"() {
file("build.gradle") << """
apply plugin: "scala-base"
sourceSets {
custom
}
${mavenCentralRepository()}
dependencies {
customImplementation "${scalaDependency(version.toString())}"
}
task scaladoc(type: ScalaDoc) {
classpath = sourceSets.custom.runtimeClasspath
}
task verify {
def customCompileClasspathState = provider { configurations.customCompileClasspath.state.toString() }
def customRuntimeClasspathState = provider { configurations.customRuntimeClasspath.state.toString() }
doLast {
assert customCompileClasspathState.get() == "UNRESOLVED"
assert customRuntimeClasspathState.get() == "UNRESOLVED"
}
}
"""
expect:
succeeds("verify")
}

asodja added a commit that referenced this issue Aug 26, 2024
@asodja
Upgrade ScalaDoc to use lazy properties
9e22e06 
Except for classpath due to issue #30273.
asodja added a commit that referenced this issue Aug 26, 2024
@asodja
Upgrade ScalaDoc to use lazy properties
a434b8b 
Except for classpath due to issue #30273.
lptr pushed a commit that referenced this issue Aug 27, 2024
@asodja @lptr
Upgrade Groovydoc to use lazy properties
2bf15c9 
Except for classpath due to issue #30273.
asodja added a commit that referenced this issue Aug 28, 2024
@asodja
Upgrade ScalaDoc to use lazy properties
5442088 
Except for classpath due to issue #30273.
asodja added a commit that referenced this issue Aug 28, 2024
@asodja
Upgrade Groovydoc to use lazy properties
5898793 
Except for classpath due to issue #30273.
asodja added a commit that referenced this issue Aug 28, 2024
@asodja
Upgrade ScalaDoc to use lazy properties
62069c9 
Except for classpath due to issue #30273.
asodja added a commit that referenced this issue Sep 6, 2024
@asodja
Upgrade Groovydoc to use lazy properties
2237d2f 
Except for classpath due to issue #30273.
asodja added a commit that referenced this issue Sep 6, 2024
@asodja
Upgrade ScalaDoc to use lazy properties
914c6d1 
Except for classpath due to issue #30273.
asodja added a commit that referenced this issue Sep 6, 2024
@asodja
Upgrade Groovydoc to use lazy properties
df87be4 
Except for classpath due to issue #30273.
asodja added a commit that referenced this issue Sep 6, 2024
@asodja
Upgrade ScalaDoc to use lazy properties
9774976 
Except for classpath due to issue #30273.
asodja added a commit that referenced this issue Sep 17, 2024
@asodja
Upgrade Groovydoc to use lazy properties
62ef6eb 
Except for classpath due to issue #30273.
asodja added a commit that referenced this issue Sep 17, 2024
@asodja
Upgrade ScalaDoc to use lazy properties
cc097fa 
Except for classpath due to issue #30273.
asodja added a commit that referenced this issue Sep 19, 2024
@asodja
Upgrade Groovydoc to use lazy properties
8b2db61 
Except for classpath due to issue #30273.
asodja added a commit that referenced this issue Sep 19, 2024
@asodja
Upgrade ScalaDoc to use lazy properties
bc3579c 
Except for classpath due to issue #30273.
asodja added a commit that referenced this issue Sep 19, 2024
@asodja
Upgrade Groovydoc to use lazy properties
8b970c5 
Except for classpath due to issue #30273.
asodja added a commit that referenced this issue Sep 19, 2024
@asodja
Upgrade ScalaDoc to use lazy properties
eca138e 
Except for classpath due to issue #30273.
asodja added a commit that referenced this issue Sep 20, 2024
@asodja
Upgrade Groovydoc to use lazy properties
055205b 
Except for classpath due to issue #30273.
asodja added a commit that referenced this issue Sep 20, 2024
@asodja
Upgrade ScalaDoc to use lazy properties
d1e509d 
Except for classpath due to issue #30273.
asodja added a commit that referenced this issue Sep 23, 2024
@asodja
Upgrade Groovydoc to use lazy properties
8d1df5f 
Except for classpath due to issue #30273.
asodja added a commit that referenced this issue Sep 23, 2024
@asodja
Upgrade ScalaDoc to use lazy properties
3579225 
Except for classpath due to issue #30273.
asodja added a commit that referenced this issue Sep 25, 2024
@asodja
Upgrade Groovydoc to use lazy properties
12e9de5 
Except for classpath due to issue #30273.
asodja added a commit that referenced this issue Sep 25, 2024
@asodja
Upgrade ScalaDoc to use lazy properties
d334e2d 
Except for classpath due to issue #30273.
asodja added a commit that referenced this issue Oct 4, 2024
@asodja
Upgrade Groovydoc to use lazy properties
390ce94 
Except for classpath due to issue #30273.
asodja added a commit that referenced this issue Oct 4, 2024
@asodja
Upgrade ScalaDoc to use lazy properties
ba3f936 
Except for classpath due to issue #30273.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:bug in:provider-api property lazy provider MapProperty ListProperty DirectoryProperty p:lazy-migration Issues covered by migration to an all-lazy API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asodja