Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[editorial] Add timelines to all attributes/slots, assorted editing #4796

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kainino0x
Copy link
Contributor

  • Add timelines (content/device/queue/immutable) to all attributes/slots
    • Move texture/queryset destroy() steps to device timeline
    • (Didn't add timelines to <dl>s for dictionaries, enum values, and consts, because they're effectively always immutable. Methods <dl>s of course shouldn't have them because methods have timeline steps inside of them.)
  • Normalize most language for properties/attributes/internal slots
  • Simplify GPUQuerySet.[[state]] into a boolean
  • Order readonly properties first
  • References to {{boolean}}
  • Minor text clarifications

(Unfortunately will have some minor merge conflicts with other PRs I've opened.)

@kainino0x kainino0x added copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.) api WebGPU API labels Jul 26, 2024
@kainino0x kainino0x added this to the Milestone 0 milestone Jul 26, 2024
@kainino0x kainino0x requested a review from toji July 26, 2024 02:24
Copy link
Contributor

github-actions bot commented Jul 26, 2024

Previews, as seen when this build job started (a1e06d6):
WebGPU webgpu.idl | Explainer | Correspondence Reference
WGSL grammar.js | wgsl.lalr.txt

Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this very nice cleanup.

{{GPUTexture}} has the following internal slots:

<dl dfn-type=attribute dfn-for=GPUTexture>
: <dfn>\[[size]]</dfn>, of type {{GPUExtent3D}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarification note for future generations: this removal is intentional, and has been replaced by direct references to the texture width/height/depthOrArrayLayers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api WebGPU API copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants