-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove maxInterStageShaderComponents #4783
Conversation
Previews, as seen when this build job started (1696617): |
For the record here"s how I"m thinking we can deprecate/remove this from Chromium (taking slight advantage of #4781):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I share Kai"s preference for landing after #4781
Fixes 4688
(Rebased with no change after landing #4781) |
gpuweb/gpuweb@23db3e4...2dc56f2 * Handle device limits being undefined * gpuweb/gpuweb#4781 * Remove the maxInterStageShaderComponents limit * gpuweb/gpuweb#4783 Bug: 368022291 Change-Id: I548a1c2e841aa40feb0234214a9dc75289ffcb13 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/207095 Commit-Queue: Geoff Lang <[email protected]> Reviewed-by: Corentin Wallez <[email protected]>
Prefer to land this after #4781, if we accept thatDone and rebasedFixes #4688