Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note that enabling features can have performance impact #4778

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

kainino0x
Copy link
Contributor

We had this note feature for limits, but not features.

The particular thing that inspired this note is the fact that Metal requires setting a render pass flag to use indirect command buffers: https://developer.apple.com/documentation/metal/mtlrenderpipelinestate/2966639-supportindirectcommandbuffers?language=objc

We had this feature for limits, but not features.

The particular thing that inspired this note is the fact that Metal
requires setting a render pass flag to use indirect command buffers:
https://developer.apple.com/documentation/metal/mtlrenderpipelinestate/2966639-supportindirectcommandbuffers?language=objc
@kainino0x kainino0x added copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.) api WebGPU API labels Jul 24, 2024
@kainino0x kainino0x added this to the Milestone 1 milestone Jul 24, 2024
@kainino0x kainino0x requested a review from toji July 24, 2024 04:30
Copy link
Contributor

github-actions bot commented Jul 24, 2024

Previews, as seen when this build job started (1a3dc1a):
WebGPU webgpu.idl | Explainer | Correspondence Reference
WGSL grammar.js | wgsl.lalr.txt

Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toji toji merged commit 26e66b0 into gpuweb:main Aug 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api WebGPU API copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants