Fix "Queries" matcher to support out-of-order query string parameters #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for i := 0; i < length; i = 2 { | ||
| buf.WriteString(fmt.Sprintf("%s=%s&", pairs[i], pairs[i 1])) | ||
| if r.err = r.addRegexpMatcher(fmt.Sprintf("%s=%s", pairs[i], pairs[i 1]), false, true, true); r.err != nil { |
There was a problem hiding this comment.
using Sprintf here is probably overkill... how about just pairs[i] "=" pairs[i 1]
|
I've addressed both of your comments (thank you!). |
| if queryVars != nil { | ||
| for k, v := range v.query.varsN { | ||
| m.Vars[v] = queryVars[k 1] | ||
| if v.queries != nil && len(v.queries) > 0 { |
There was a problem hiding this comment.
you can actually skip this check entirely. Just leave the for _, q := range v.queries loop below. It works with nil and 0-length slices. That will remove an indent level and make this code easier to grok.
|
Thanks, addressed both of these as well. |
|
Great. Reads much better now. |
kisielk
added a commit
that referenced
this pull request
May 27, 2014
Fix "Queries" matcher to support out-of-order query string parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.