Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call WriteHeader after setting other header(s) in the example #442

Merged
merged 1 commit into from
Jan 25, 2019
Merged

Call WriteHeader after setting other header(s) in the example #442

merged 1 commit into from
Jan 25, 2019

Conversation

timucingelici
Copy link
Contributor

From the docs: Changing the header map after a call to WriteHeader (or
Write) has no effect unless the modified headers are
trailers.

@timucingelici
Call WriteHeader after setting other header(s) in the example
35634bb 
From the docs: Changing the header map after a call to WriteHeader (or
Write) has no effect unless the modified headers are
trailers.
@elithrar
Copy link
Contributor

Good catch, thanks!

@elithrar elithrar merged commit 797e653 into gorilla:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timucingelici @elithrar