Simplify extractVars, fixes edge cases. #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a (pre-fix) failing test case for this? |
Also make sure all regexp groups in tests are non-capturing.
|
@elithrar I've added a test which fails before the fix. |
|
Thanks for this @neelance! |
ldez
added a commit
to containous/mux
that referenced
this pull request
Oct 20, 2017
This reverts commit 0b13a92.
juliens
pushed a commit
to juliens/mux
that referenced
this pull request
Jun 15, 2022
This reverts commit 0b13a92.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation was failing in a case where there are two route vars right next to each other and the second one matched the empty string. Because of that,
prevEnd < matches[i 1]evaluated tofalseand the matches got assigned to the wrong names.Having a capturing regexp group in a route pattern is never useful. This commit changes the tests accordingly. Another option would be to automatically turn capturing groups into non-capturing ones (adding the
?:automatically).