Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Unit-test #31

Merged
merged 1 commit into from
May 25, 2016
Merged

Fix Unit-test #31

merged 1 commit into from
May 25, 2016

Conversation

yuokada
Copy link
Contributor

@yuokada yuokada commented May 25, 2016 •
edited
Loading

I feel that this unit-test is wrong.
And, I found this issue by ineffassign.

% go get github.com/gordonklaus/ineffassign
% ineffassign .
/path/to/context/context_test.go:71:2: values assigned and not used

@yuokada yuokada changed the title Fix typo [WIP] Fix typo May 25, 2016
@yuokada yuokada changed the title [WIP] Fix typo Fix typo May 25, 2016
@yuokada yuokada closed this May 25, 2016
@yuokada yuokada reopened this May 25, 2016
@yuokada yuokada closed this May 25, 2016
@yuokada yuokada deleted the fix/typo branch May 25, 2016 15:09
@yuokada yuokada restored the fix/typo branch May 25, 2016 15:09
@yuokada yuokada reopened this May 25, 2016
@yuokada yuokada changed the title Fix typo Fix Uni-ttest May 25, 2016
@yuokada yuokada changed the title Fix Uni-ttest Fix Unit-test May 25, 2016
@yuokada
Copy link
Contributor Author

yuokada commented May 25, 2016

Sorry, previous commit was incomplete.
A pr is currently OK.

@kisielk kisielk merged commit aed02d1 into gorilla:master May 25, 2016
@kisielk
Copy link
Contributor

kisielk commented May 25, 2016

Change looks correct to me. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuokada @kisielk