Add AdRequest.omidAccessModeRules property to google-ima shim #3911
Conversation
Add the missing AdRequest.omidAccessModeRules[1] property, to avoid breaking websites that access it. 1 - https://developers.google.com/interactive-media-ads/docs/sdks/html5/client-side/reference/js/google.ima.AdsRequest#omidAccessModeRules
|
@gorhill if you'd like to test this, browse to https://www.corriere.it/video-articoli/2022/07/13/missione-wwf-liberare-mare-plastica/9abb64de-029d-11ed-a0cc-ad3c68cacbae.shtml (making sure google-ima.js is being redirected to the shim) and try playing the video. Without the fix, I found the video wouldn't play and an error showed up in the console about the missing property. |
|
On my side, the video still doesn't play with uBO default lists the filter What works to unbreak the video on our side is |
|
Dang OK, yea there's quite a lot going on in that website. It's probably not the best test case, but it's the only one I have. In the DuckDuckGo Privacy Essentials extension, this change fixed video playback. But there we are also blocking and redirecting a bunch of other requests. Reproducing the issue to see it being fixed here might be a PITA, sorry :/. FWIW I am quite confident in the change though, the website attempts to do But yea, no pressure if you'd rather not merge. Just wanted to share this back! Sorry I don't have a good test website. |
|
I will investigate more when I get the time to find out where it fails on my side. |
|
OK cool, sounds good. If it helps, here's a (compressed) HAR file showing which requests the DuckDuckGo extension redirected/blocked/allowed. |
Add the missing AdRequest.omidAccessModeRules[1] property, to avoid
breaking websites that access it.
1 - https://developers.google.com/interactive-media-ads/docs/sdks/html5/client-side/reference/js/google.ima.AdsRequest#omidAccessModeRules