Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

are termsAndConditionsDialogOptions and onNavigationViewControllerCreated mandatory if we only want to show a simple map without navigation? #39

Closed
ziga-hvalec opened this issue Feb 26, 2024 · 5 comments
Closed

are termsAndConditionsDialogOptions and onNavigationViewControllerCreated mandatory if we only want to show a simple map without navigation? #39

ziga-hvalec opened this issue Feb 26, 2024 · 5 comments
Assignees
@jokerttu @ArturoSalazarB16
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@ziga-hvalec
Copy link
Collaborator

Like title says, we would like to only show a simple map without navigation. Are onNavigationViewControllerCreated and termsAndConditionsDialogOptions in this case still mandatory?
@ziga-hvalec ziga-hvalec added triage me I really want to be triaged. type: question Request for information or clarification. Not an issue. labels Feb 26, 2024
@ArturoSalazarB16
Copy link
Contributor

ArturoSalazarB16 commented Feb 26, 2024 •
edited
Loading

Hi @ziga-hvalec, thanks for raising this.

For the scope of the initial preview release, TOS are required even for a plain MapView.
However, we're working to make that more flexible so it's not mandatory. We don't have a concrete timeline yet, but will share one once we do.

CC @caio1985

@ziga-hvalec
Copy link
Collaborator Author

Great thanks. For us most users will open navigation first anyway but for some that don't it would be nice to not show this.

@ArturoSalazarB16
Copy link
Contributor

FYI @caio1985

@ArturoSalazarB16 ArturoSalazarB16 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: question Request for information or clarification. Not an issue. triage me I really want to be triaged. labels Apr 10, 2024
@ArturoSalazarB16
Copy link
Contributor

Hi @jokerttu - is this something that would be addressed with the architectural changes we discussed today?

@jokerttu
Copy link
Contributor

@ziga-hvalec the behaviour was changed and landed with #199
You do not need to use termsAndConditionsDialogOptions anymore to initialize map view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jokerttu jokerttu

@ArturoSalazarB16 ArturoSalazarB16

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jokerttu @ArturoSalazarB16 @ziga-hvalec