Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix links error when using GitHub Enterprise #2350

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

goatwu1993
Copy link
Contributor

@goatwu1993 goatwu1993 commented Aug 7, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

With this update, while release-please/release-please-actions runs in GitHub Enterprise actions/workflow, the links by default is correct.

Fixes #2351 🦕

@goatwu1993 goatwu1993 requested review from a team as code owners August 7, 2024 10:37
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Aug 7, 2024
@goatwu1993 goatwu1993 closed this Aug 8, 2024
@goatwu1993 goatwu1993 reopened this Aug 8, 2024
@goatwu1993 goatwu1993 changed the title fix: fix some links point to github.com when using github enterprise fix: fix links error when using GitHub Enterprise Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using release-please on GitHub enterprise, some links at changelog/release points to github
2 participants