Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add performance tests #595

Merged
merged 21 commits into from
Aug 10, 2022
Merged

test: add performance tests #595

merged 21 commits into from
Aug 10, 2022

Conversation

daniel-sanche
Copy link
Contributor

This PR contributes a set of performance tests. The performance tests run a benchmark of some of the most common library usages, and will raise an error if performance significantly drops in a future update to the code. It also breaks down which code paths/functions are making up most of the execution time, so we can work to optimize the slow parts in the future

This PR modifies the noxfile, which may get overwritten by owlbot. I may need to modify it as a higher-level template

Fixes #863

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: logging Issues related to the googleapis/python-logging API. labels Aug 4, 2022
@daniel-sanche daniel-sanche changed the title [DRAFT] test: add performance tests test: add performance tests Aug 9, 2022
@daniel-sanche daniel-sanche marked this pull request as ready for review August 9, 2022 17:07
@daniel-sanche daniel-sanche requested review from a team as code owners August 9, 2022 17:07
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 9, 2022
Copy link
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dan - this is a great change. The only thing that I would ask here is to add to PR some high level explanation or diagram how the tests are designed and which APIs is does tests.

@daniel-sanche daniel-sanche merged commit 44f17f5 into main Aug 10, 2022
@daniel-sanche daniel-sanche deleted the performance_tests branch August 10, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/python-logging API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add performance tests
3 participants