Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bigquery): add support of use_avro_logical_types for extract jobs #9642

Merged
merged 3 commits into from
Nov 20, 2019
Merged

feat(bigquery): add support of use_avro_logical_types for extract jobs #9642

merged 3 commits into from
Nov 20, 2019

Conversation

HemangChothani
Copy link
Contributor

Fixes #9624

@HemangChothani HemangChothani requested a review from a team November 8, 2019 11:22
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2019
@HemangChothani
Copy link
Contributor Author

kokoro - BigQuery failure related to 9633 issue.

@HemangChothani HemangChothani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2019
tswast
tswast reviewed Nov 12, 2019
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once nit is addressed.

bigquery/google/cloud/bigquery/job.py Outdated Show resolved Hide resolved
@plamut
Copy link
Contributor

plamut commented Nov 13, 2019 •
edited
Loading

@HemangChothani Thanks for the cleanup, let's add it to the original use_avro_logical_types() method, too (boy scouts and such).

Edit: Great, thanks!

@tswast tswast merged commit 1959307 into googleapis:master Nov 20, 2019
@HemangChothani HemangChothani deleted the BigQuery_Add_use_avro_logical_types_for_extract_jobs branch December 17, 2019 12:17
This was referenced Jan 29, 2020
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery: Add support for use_avro_logical_types for extract jobs
5 participants
@HemangChothani @plamut @tswast @googlebot @yoshi-kokoro