Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add python 2 EOL warning to reference documentation #9036

Merged
merged 6 commits into from
Nov 11, 2019
Merged

docs: add python 2 EOL warning to reference documentation #9036

merged 6 commits into from
Nov 11, 2019

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Aug 16, 2019 •
edited
Loading

This PR adds a banner like the one below for all libraries:

Cloud Asset Python 2 Deprecation and EOL

@busunkim96 busunkim96 added the type: docs Improvement to the documentation for an API. label Aug 16, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 16, 2019
@busunkim96 busunkim96 mentioned this pull request Aug 16, 2019
Closed
3 tasks
@crwilcox
Copy link
Contributor

crwilcox commented Nov 6, 2019

We can link to https://cloud.google.com/python/docs/python2-sunset/

@busunkim96 busunkim96 changed the title Docs: Add Python 2 EOL warning to reference documentation. docs: add python 2 EOL warning to reference documentation. Nov 6, 2019
@busunkim96 busunkim96 mentioned this pull request Nov 7, 2019
Merged
@busunkim96
Copy link
Contributor Author

Working on getting this added to the enerator

@busunkim96 busunkim96 marked this pull request as ready for review November 9, 2019 00:35
@busunkim96 busunkim96 requested a review from a team November 9, 2019 00:35
crwilcox
crwilcox approved these changes Nov 9, 2019
View reviewed changes
Copy link
Contributor

@crwilcox crwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for batching this up.

@busunkim96
Copy link
Contributor Author

Asset - system test failure (VPCSC)
BigQuery - system test failure (fixed in #9649)
Resource Manager - needs blackening
Security Center - snippets failure (resource names too long)
Storage - most likely a flake, failed only in 2.7
Trace - system test failure (VPCSC)

@busunkim96 busunkim96 changed the title docs: add python 2 EOL warning to reference documentation. docs: add python 2 EOL warning to reference documentation Nov 11, 2019
@tseaver
Copy link
Contributor

tseaver commented Nov 11, 2019

The current storage failure is an actual buggy unit test (query string parameter ordering):

E   Expected: request(data=<ANY>, headers=<ANY>, method='POST', url='https://storage.googleapis.com/storage/v1/b?project=OTHER_PROJECT&userProject=USER_PROJECT')
E   Actual: request(data='{"name": "bucket-name"}', headers={'Content-Type': 'application/json', 'X-Goog-API-Client': 'gcloud-python/1.22.0  gl-python/3.5.3 gax/1.14.3 gccl/1.22.0', 'User-Agent': 'gcloud-python/1.22.0  gl-python/3.5.3 gax/1.14.3 gccl/1.22.0', 'Accept-Encoding': 'gzip'}, method='POST', url='https://storage.googleapis.com/storage/v1/b?userProject=USER_PROJECT&project=OTHER_PROJECT')

Reported as #9714.

@busunkim96 busunkim96 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 11, 2019
parthea pushed a commit that referenced this pull request Jun 4, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
f960d65
parthea pushed a commit that referenced this pull request Jun 4, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
faf113f
parthea pushed a commit that referenced this pull request Jun 4, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
ad773f4
parthea pushed a commit that referenced this pull request Jun 4, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
9415c9e
parthea pushed a commit that referenced this pull request Jun 4, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
f66fc9e
parthea pushed a commit that referenced this pull request Jun 4, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
3046894
parthea pushed a commit that referenced this pull request Jun 4, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
9ea8f1e
parthea pushed a commit that referenced this pull request Jun 4, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
7a27b50
parthea pushed a commit that referenced this pull request Jul 6, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
9ac7e65
parthea pushed a commit that referenced this pull request Aug 15, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
5b1083d
parthea pushed a commit that referenced this pull request Sep 22, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
87a5de9
parthea pushed a commit that referenced this pull request Sep 22, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
094dd8c
parthea pushed a commit that referenced this pull request Sep 22, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
6fbbb0c
parthea pushed a commit that referenced this pull request Sep 22, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
7ba2366
parthea pushed a commit that referenced this pull request Sep 22, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
b32b3ab
parthea pushed a commit that referenced this pull request Sep 22, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
3dd715f
parthea pushed a commit that referenced this pull request Sep 22, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
78e932f
parthea pushed a commit that referenced this pull request Sep 22, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
e19a2ba
parthea pushed a commit that referenced this pull request Oct 21, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
ba75c02
parthea pushed a commit that referenced this pull request Oct 21, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
bba59bb
parthea pushed a commit that referenced this pull request Oct 21, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
8584805
parthea pushed a commit that referenced this pull request Oct 21, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
24bacd0
parthea pushed a commit that referenced this pull request Oct 21, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
929565f
parthea pushed a commit that referenced this pull request Oct 21, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
168a4a6
parthea pushed a commit that referenced this pull request Oct 21, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
9a9ecb6
parthea pushed a commit that referenced this pull request Oct 21, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
a490b43
parthea pushed a commit that referenced this pull request Oct 22, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
8052d56
parthea pushed a commit that referenced this pull request Oct 22, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
1d9a5d4
parthea pushed a commit that referenced this pull request Oct 22, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
1e47c16
parthea pushed a commit that referenced this pull request Oct 31, 2023
@busunkim96
docs: add python 2 sunset banner to documentation (#9036)
a4bd221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@crwilcox crwilcox crwilcox approved these changes

@pradn pradn pradn approved these changes

@anguillanneuf anguillanneuf Awaiting requested review from anguillanneuf

@frankyn frankyn Awaiting requested review from frankyn

@plamut plamut Awaiting requested review from plamut

@tseaver tseaver Awaiting requested review from tseaver

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@busunkim96 @crwilcox @tseaver @tswast @pradn @googlebot @yoshi-kokoro