BigQuery: Fix schema recognition of struct field types #9001
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A struct field can be referred to as "RECORD" or "STRUCT", and this commit assures that the
to_api_repr()
logic is correct. It also movesSTRUCT_TYPES
from_pandas_helpers
toschema
where it belongs more naturally IMO.Discovered this while writing the "all types" system test, and tried to create a STRUCT field using the standard SQL type name
"STRUCT"
.How to test
Actual result (before the fix):
The server responds with an error:
Expected result (after the fix):
The table is successfully created.