feat(bigquery): check json_rows arg type in insert_rows_json() #10162

IlyaFaer · 2020-01-16T13:04:56Z

IlyaFaer

@tswast, maybe we should do the same thing for insert_rows()? The situation in it is very close to insert_rows_json():

google-cloud-python/bigquery/google/cloud/bigquery/client.py

Lines 2345 to 2364 in cb32c36

    
               def insert_rows(self, table, rows, selected_fields=None, **kwargs): 
        
                   """Insert rows into a table via the streaming API. 
        
                   See 
        
                   https://cloud.google.com/bigquery/docs/reference/rest/v2/tabledata/insertAll 
        
                   Args: 
        
                       table (Union[ \ 
        
                           google.cloud.bigquery.table.Table, \ 
        
                           google.cloud.bigquery.table.TableReference, \ 
        
                           str, \ 
        
                       ]): 
        
                           The destination table for the row data, or a reference to it. 
        
                       rows (Union[Sequence[Tuple], Sequence[dict]]): 
        
                           Row data to be inserted. If a list of tuples is given, each 
        
                           tuple should contain data for each schema field on the 
        
                           current table and in the same order as the schema fields. If 
        
                           a list of dictionaries is given, the keys must include all 
        
                           required fields in the schema. Keys which do not correspond 
        
                           to a field in the schema are ignored.

IlyaFaer · 2020-01-16T13:06:59Z

bigquery/google/cloud/bigquery/client.py

@@ -2506,6  2506,8 @@ def insert_rows_json(
                identifies the row, and the "errors" key contains a list of
                the mappings describing one or more problems with the row.
        """
+        if not isinstance(json_rows, collections_abc.Sequence):
+            raise TypeError("json_rows argument should be a sequence of dicts")


Made it with isinstance(). It'll be True for sequences, but not for dicts:

tswast · 2020-01-17T15:31:54Z

maybe we should do the same thing for insert_rows()? The situation in it is very close to insert_rows_json():

Yes, that's a good idea.

IlyaFaer added 2 commits January 15, 2020 13:43

feat(bigquery): check json_rows arg type in insert_rows_json()

fc1f245

Spelling

cb32c36

IlyaFaer added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: bigquery Issues related to the BigQuery API. labels Jan 16, 2020

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 16, 2020

IlyaFaer commented Jan 16, 2020

View reviewed changes

IlyaFaer marked this pull request as ready for review January 16, 2020 13:46

IlyaFaer requested a review from a team January 16, 2020 13:46

tswast approved these changes Jan 17, 2020

View reviewed changes

tswast merged commit ae54dc3 into googleapis:master Jan 17, 2020

IlyaFaer mentioned this pull request Jan 20, 2020

feat(bigquery): check rows arg type in insert_rows() #10174

Merged

This was referenced Jan 30, 2020

[CHANGE ME] Re-generated container to pick up changes in the API or client library generator. #10256

Closed

[CHANGE ME] Re-generated datastore to pick up changes in the API or client library generator. #10261

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(bigquery): check json_rows arg type in insert_rows_json() #10162

feat(bigquery): check json_rows arg type in insert_rows_json() #10162

IlyaFaer commented Jan 16, 2020

IlyaFaer left a comment •

edited

Loading

IlyaFaer Jan 16, 2020

tswast commented Jan 17, 2020

	def insert_rows(self, table, rows, selected_fields=None, **kwargs):
	"""Insert rows into a table via the streaming API.

	See
	https://cloud.google.com/bigquery/docs/reference/rest/v2/tabledata/insertAll

	Args:
	table (Union[ \
	google.cloud.bigquery.table.Table, \
	google.cloud.bigquery.table.TableReference, \
	str, \
	]):
	The destination table for the row data, or a reference to it.
	rows (Union[Sequence[Tuple], Sequence[dict]]):
	Row data to be inserted. If a list of tuples is given, each
	tuple should contain data for each schema field on the
	current table and in the same order as the schema fields. If
	a list of dictionaries is given, the keys must include all
	required fields in the schema. Keys which do not correspond
	to a field in the schema are ignored.

feat(bigquery): check json_rows arg type in insert_rows_json() #10162

feat(bigquery): check json_rows arg type in insert_rows_json() #10162

Conversation

IlyaFaer commented Jan 16, 2020

IlyaFaer left a comment • edited Loading

Choose a reason for hiding this comment

IlyaFaer Jan 16, 2020

Choose a reason for hiding this comment

tswast commented Jan 17, 2020

IlyaFaer left a comment •

edited

Loading