Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual region tags #350

Merged
merged 4 commits into from
Dec 7, 2020
Merged

Conversation

PierrickVoulet
Copy link
Contributor

No description provided.

@PierrickVoulet PierrickVoulet marked this pull request as draft December 4, 2020 17:21
@PierrickVoulet PierrickVoulet marked this pull request as ready for review December 4, 2020 23:17
Copy link
Contributor

@wihl wihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in advanced_operations/add_dynamic_search_ads.py, if nesting is allowed, you can add add_dynamic_search_ads_3 around lines 173-175 (so Java isn't the only language)

@wihl wihl self-requested a review December 7, 2020 21:37
@PierrickVoulet
Copy link
Contributor Author

in advanced_operations/add_dynamic_search_ads.py, if nesting is allowed, you can add add_dynamic_search_ads_3 around lines 173-175 (so Java isn't the only language)

Nesting is allowed. This PR is only about migrating existing includecodes so I prefer to keep it as-is. I hope to work on filling those gaps soon.

@wihl wihl merged commit c4c9788 into googleads:master Dec 7, 2020
BenRKarl pushed a commit that referenced this pull request Jan 7, 2021
* Add manual region tags

* Add region tags

* Refine code snippet content

Co-authored-by: pierrick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants