New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enhance duration parser #884

Merged

antonmedv merged 2 commits into google:main from antongolub:util-imprs

Sep 6, 2024

Collaborator

antongolub commented Sep 6, 2024

assert.throws(() => parseDuration('f2ms'))
assert.throws(() => parseDuration('2mss'))

Tests pass
Appropriate changes to README are included in PR

antongolub added 2 commits

September 6, 2024 11:18


          perf: replace some regexes with str.includes()

6fab91b


          fix: enhance duration parser

b0c3184

antongolub force-pushed the util-imprs branch from 192863a to b0c3184 Compare

September 6, 2024 08:18

antongolub requested a review from antonmedv

September 6, 2024 08:19

antonmedv approved these changes

View reviewed changes

antonmedv merged commit 76463de into google:main

17 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet