Improve zero discriminant detection for enums #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1527 +/- ##
=======================================
Coverage 87.70% 87.70%
=======================================
Files 15 15
Lines 5563 5563
=======================================
Hits 4879 4879
Misses 684 684 ☔ View full report in Codecov by Sentry. |
joshlf
requested changes
Jul 16, 2024
djkoloski
force-pushed
the
better_zero_variant_detection
branch
2 times, most recently
from
91db103 to
8a2b68b
Compare
joshlf
requested changes
Jul 17, 2024
djkoloski
force-pushed
the
better_zero_variant_detection
branch
from
8a2b68b to
e6e79f7
Compare
Enums with negative explicit discriminants can allow variants which are not first but have an implicit discriminant to be assigned a discriminant of zero. This also adds a help message explaining that the derive macro ignores discriminants set to const expressions.
djkoloski
force-pushed
the
better_zero_variant_detection
branch
from
e6e79f7 to
4d4956e
Compare
joshlf
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enums with negative explicit discriminants can allow variants which are not first but have an implicit discriminant to be assigned a discriminant of zero.