Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golangci-lint version #2852

Merged
merged 3 commits into from
Nov 25, 2022

Conversation

JAORMX
Copy link
Collaborator

@JAORMX JAORMX commented Nov 22, 2022

This PR upgrades the golangci-lint version from v1.47.3 to v1.50.1

It also replaces some deprecated golangci-lint checks.

Finally, it addresses warnings from golangci-lint which were mostly just package documentation related.

Checklist

This upgrades the golangci-lint version from v1.47.3 to v1.50.1

Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX requested a review from a team as a code owner November 22, 2022 07:02
@JAORMX JAORMX requested a review from mhutchinson November 22, 2022 07:02
@roger2hk
Copy link
Contributor

/gcbrun

Both `deadcode` and `varcheck` were deprecated in golangci-lint version
v1.49.0. This replaces them with the `unused` check.

Signed-off-by: Juan Antonio Osorio <[email protected]>
This appeaces the golangci-lint `revive` check.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@roger2hk
Copy link
Contributor

/gcbrun

@roger2hk
Copy link
Contributor

@AlCutter PTAL to see if the copyright notice fulfills the Google requirement.

@roger2hk roger2hk requested review from AlCutter and removed request for mhutchinson November 23, 2022 13:06
Copy link
Member

@AlCutter AlCutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Os!

@AlCutter AlCutter merged commit e5178ca into google:master Nov 25, 2022
@JAORMX JAORMX deleted the lint-upgrades branch November 25, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants