Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: selectively display specific slice #805

Open
zclllyybb opened this issue May 29, 2024 · 3 comments
Open

feature request: selectively display specific slice #805

zclllyybb opened this issue May 29, 2024 · 3 comments

Comments

@zclllyybb
Copy link

We can click "Slices with the same name" for the slices' name to show all slices with the same name in a new table. And for args of slices there's "Find slices with same arg value" as well.
But they only support showing the result slices in a new table. Can I get them in the display panel? that is, hide the other disqualified slices when displaying.
@primiano
Copy link
Collaborator

Good idea. Why don't you put together a patch?

@zclllyybb
Copy link
Author

I'm willing to contribute about this. But I'm not very familiar with perfetto yet. Could you tell me which part of the code I need to care about?

@LalitMaganti
Copy link
Collaborator

The slice details panel is a good starting point: https://cs.android.com/android/platform/superproject/main/ /main:external/perfetto/ui/src/frontend/slice_details.ts;l=55?q="Slices with the same name"

I think if you start from there and explore how "Slices with the same name" is implemented for example, that should point you in the right direction!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@LalitMaganti @primiano @zclllyybb