This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Initial attempt at a MacOS port. #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMNGeoffrey
approved these changes
Oct 27, 2020
This builds and produces a seemingly functional set of binaries. Only tested on MacOS x86 laptop with XCode 12.
chandlerc
force-pushed
the
macos-build
branch
from
11d942d to
d44a4aa
Compare
|
PTAL, had to mark a test as local, but now also passes all tests on Mac! |
GMNGeoffrey
approved these changes
Oct 27, 2020
Comment on lines
468
to
470
| tags = [ | ||
| "local", # Not compatible with the sandbox on MacOS | ||
| ], |
There was a problem hiding this comment.
Just note that this appears to make the test take about 10 times as long. Would it be better to disable the gid/uid test entirely with --gtest_filter?
There was a problem hiding this comment.
I've checked and at least for me I'm not seeing a significant difference ... on my Linux machine, it takes about 8s to run the test just like on the buildkite instance? I think it's just cached vs. uncached.
I'd prefer this to skipping the test as the test granularity isn't super narrow -- we'd lose all permission management tests. =/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds and produces a seemingly functional set of binaries. Only
tested on MacOS x86 laptop with XCode 12.
I've added some TODOs around parts that still seem brittle.