Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove an unnecessary null pointer check #338

Closed
elfring opened this issue Jan 28, 2016 · 4 comments
Closed

Remove an unnecessary null pointer check #338

elfring opened this issue Jan 28, 2016 · 4 comments
Labels
bug

Comments

@elfring
Copy link

elfring commented Jan 28, 2016

An extra null pointer check is not needed in the function "Table::Open".
@elfring elfring mentioned this issue Jan 28, 2016
Closed
@cmumford
Copy link
Contributor

Are you referring to:

if (index_block) delete index_block;

@elfring
Copy link
Author

elfring commented Jan 30, 2016

@cmumford: Yes.

@cmumford
Copy link
Contributor

cmumford commented Feb 2, 2016

Has been fixed in our internal repo. Will push this change out (hopefully) this week.

@cmumford cmumford added the bug label Feb 2, 2016
cmumford added a commit that referenced this issue Mar 31, 2016
@cmumford
Deleted redundant null ptr check prior to delete.
3211343 
Fixes issue #338.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=113439460
@elfring
Copy link
Author

elfring commented Aug 11, 2016

Thanks for your small source code improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elfring @cmumford