Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insufficient definitions in platform endianness detection #143

Closed
cmumford opened this issue Sep 9, 2014 · 1 comment
Closed

Insufficient definitions in platform endianness detection #143

cmumford opened this issue Sep 9, 2014 · 1 comment
Assignees
@cmumford

Comments

@cmumford
Copy link
Contributor

cmumford commented Sep 9, 2014

Original issue 137 created by mike.volokhov on 2013-01-05T09:21:29.000Z:

There is some mess across platforms in how they define endianness, especially in number of underscores in definition prefix, i.e. __BYTE_ORDER vs _BYTE_ORDER and so on.

The port/port_posix.h tries to handle it, but on some platforms, perticularly, on NetBSD 6.x, compiler fails with the following error:

c -O2 -I/usr/pkg/include -I. -I./include -fno-builtin-memcmp -D_REENTRANT -DOS_NETBSD -DLEVELDB_PLATFORM_POSIX -DSNAPPY -O2 -DNDEBUG -c db/builder.cc -o db/builder.o
In file included from ./port/port.h:14:0,
from ./db/filename.h:14,
from db/builder.cc:7:
./port/port_posix.h:67:35: error: '__BYTE_ORDER' was not declared in this scope
./port/port_posix.h:67:35: error: '__LITTLE_ENDIAN' was not declared in this scope
gmake: *** [db/builder.o] Error 1

Exactly the same case exists for FreeBSD before it was handled in Issue 98 (https://code.google.com/p/leveldb/issues/detail?id=98).

I'd like to suggest the following patch so the endianness detection could be handled a little bit more gracefully:

--- port/port_posix.h.orig 2012-12-27 18:32:31.000000000 0000
port/port_posix.h
@@ -7,6 7,13 @@
#ifndef STORAGE_LEVELDB_PORT_PORT_POSIX_H_
#define STORAGE_LEVELDB_PORT_PORT_POSIX_H_

#ifndef __BYTE_ORDER
#define __BYTE_ORDER _BYTE_ORDER
#endif
#ifndef __LITTLE_ENDIAN
#define __LITTLE_ENDIAN _LITTLE_ENDIAN
#endif

#undef PLATFORM_IS_LITTLE_ENDIAN
#if defined(OS_MACOSX)
#include <machine/endian.h>
@cmumford
Copy link
Contributor Author

cmumford commented Sep 9, 2014

Comment #1 originally posted by frankgroeneveld on 2014-03-06T19:04:09.000Z:

This helps fix build problems on OpenBSD as well. Would be great if it could be included.

@cmumford cmumford self-assigned this Sep 9, 2014
cmumford added a commit that referenced this issue Sep 16, 2014
@cmumford
Release 1.18
803d692 
Changes are:

* Update version number to 1.18
* Replace the basic fprintf call with a call to fwrite in order to
  work around the apparent compiler optimization/rewrite failure that we are
  seeing with the new toolchain/iOS SDKs provided with Xcode6 and iOS8.
* Fix ALL the header guards.
* Createed a README.md with the LevelDB project description.
* A new CONTRIBUTING file.
* Don't implicitly convert uint64_t to size_t or int.  Either preserve it as
  uint64_t, or explicitly cast. This fixes MSVC warnings about possible value
  truncation when compiling this code in Chromium.
* Added a DumpFile() library function that encapsulates the guts of the
  "leveldbutil dump" command. This will allow clients to dump
  data to their log files instead of stdout. It will also allow clients to
  supply their own environment.
* leveldb: Remove unused function 'ConsumeChar'.
* leveldbutil: Remove unused member variables from WriteBatchItemPrinter.
* OpenBSD, NetBSD and DragonflyBSD have _LITTLE_ENDIAN, so define
  PLATFORM_IS_LITTLE_ENDIAN like on FreeBSD. This fixes:
   * issue #143
   * issue #198
   * issue #249
* Switch from <cstdatomic> to <atomic>. The former never made it into the
  standard and doesn't exist in modern gcc versions at all.  The later contains
  everything that leveldb was using from the former.
  This problem was noticed when porting to Portable Native Client where no memory
  barrier is defined.  The fact that <cstdatomic> is missing normally goes
  unnoticed since memory barriers are defined for most architectures.
* Make Hash() treat its input as unsigned.  Before this change LevelDB files
  from platforms with different signedness of char were not compatible. This
  change fixes: issue #243
* Verify checksums of index/meta/filter blocks when paranoid_checks set.
* Invoke all tools for iOS with xcrun. (This was causing problems with the new
  XCode 5.1.1 image on pulse.)
* include <sys/stat.h> only once, and fix the following linter warning:
  "Found C system header after C   system header"
* When encountering a corrupted table file, return Status::Corruption instead of
  Status::InvalidArgument.
* Support cygwin as build platform, patch is from https://code.google.com/p/leveldb/issues/detail?id=188
* Fix typo, merge patch from https://code.google.com/p/leveldb/issues/detail?id=159
* Fix typos and comments, and address the following two issues:
  * issue #166
  * issue #241
* Add missing db synchronize after "fillseq" in the benchmark.
* Removed unused variable in SeekRandom: value (issue #201)
@ghost ghost mentioned this issue May 30, 2016
Closed
maochongxin pushed a commit to maochongxin/leveldb that referenced this issue Jul 21, 2022
@dominichamon
Merge pull request google#143 from devjgm/master
eeaec44 
Updates Initialize() to work with an argv as 'char**'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmumford cmumford

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cmumford