Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Service connection API #1596

Merged
merged 5 commits into from
Aug 22, 2023
Merged

Add Service connection API #1596

merged 5 commits into from
Aug 22, 2023

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Aug 22, 2023 •
edited

WHAT

Add Service connection API.

WHY

Decent lifecycle handling for bound services.

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

luizgrp
luizgrp approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@luizgrp luizgrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It shows me as author of the first commit, I wonder what happened there.

...h/service/src/test/java/com/google/android/horologist/health/service/TestBinderConnection.kt Outdated Show resolved Hide resolved
...h/service/src/test/java/com/google/android/horologist/health/service/BinderConnectionTest.kt Show resolved Hide resolved
health/service/src/main/java/com/google/android/horologist/health/service/BinderConnection.kt Show resolved Hide resolved
...h/service/src/test/java/com/google/android/horologist/health/service/BinderConnectionTest.kt Show resolved Hide resolved
@yschimke yschimke merged commit b84f645 into google:main Aug 22, 2023
4 checks passed
@yschimke yschimke mentioned this pull request Aug 23, 2023
Merged
@yschimke yschimke deleted the service_connection branch September 11, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizgrp luizgrp luizgrp approved these changes

@garanj garanj Awaiting requested review from garanj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yschimke @luizgrp