Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use uv package manager #4136

Merged
merged 1 commit into from
Aug 22, 2024
Merged

use uv package manager #4136

merged 1 commit into from
Aug 22, 2024

Conversation

cgarciae
Copy link
Collaborator

@cgarciae cgarciae commented Aug 21, 2024

What does this PR do?

  • Adds uv.lock.
  • Moves docs/requirements.txt requirements into pyproject.toml under project.optional-dependencies.docs.
  • Updates contributing.md to use uv.
  • Removed the --no-* flags from run_all_tests.sh in favor of --only-* flags which makes is much easier to use.

@cgarciae cgarciae force-pushed the use-uv branch 20 times, most recently from ce27cee to 7b3dab2 Compare August 22, 2024 12:23
pip install -e ".[all]"
pip install -e ".[testing]"
pip install -r docs/requirements.txt
uv sync --all-extras
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does uv interact with virtual envs?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe we should keep a few lines here about installing with pip for those who don't want to curl | sh a new binary.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so there's a uv venv - we should definitely keep encouraging people to use virtual-envs in our docs.

@copybara-service copybara-service bot merged commit 2ebd398 into main Aug 22, 2024
18 checks passed
@copybara-service copybara-service bot deleted the use-uv branch August 22, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants