Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang update reorder #1201

Merged
merged 14 commits into from
Sep 15, 2022
Merged

Conversation

yalcinmelihyasin
Copy link
Contributor

@yalcinmelihyasin yalcinmelihyasin commented Sep 1, 2022

This PR updates a bunch of dependency, adds support for Apple M1 and switches Linux compiler from GCC-9 to Clang-12

Copy link
Collaborator

@kocdemir kocdemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, I'll test this on different machines for any compilation issues, bugs and stability.

tools/build/third_party/breakpad.bzl Outdated Show resolved Hide resolved
gapir/cc/surface.cpp Outdated Show resolved Hide resolved
pmuetschard and others added 6 commits September 14, 2022 15:06
- Add build target darmin_arm64
- Update breakpad to be compatible with
- Remove unused variable
- Remove unnecessary Windows patch
Copy link
Collaborator

@kocdemir kocdemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems to be working fine on m1 and linux. I believe we can fix the remaining issues, if there are any, after merging this.

@kocdemir kocdemir merged commit 3e2a4d9 into google:master Sep 15, 2022
@yalcinmelihyasin yalcinmelihyasin deleted the clang_update_reorder branch September 23, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants