Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VK_EXT_descriptor_indexing #1154

Merged
merged 4 commits into from
Aug 8, 2022
Merged

Add VK_EXT_descriptor_indexing #1154

merged 4 commits into from
Aug 8, 2022

Conversation

mikes-lunarg
Copy link
Collaborator

  • Add extension types and enums
  • Add props/features queries
  • Trace and rebuild VkDescriptorSetVariableDescriptorCountAllocateInfo
    in vkAllocateDescriptorSets
  • Trace and rebuild Flags and VkDescriptorSetLayoutBindingFlagsCreateInfo
    in vkCreateDescriptorSetLayout

Tested manually by capturing the following demos:

@mikes-lunarg
Add VK_EXT_descriptor_indexing
f408091 
- Add extension types and enums
- Add props/features queries
- Trace and rebuild VkDescriptorSetVariableDescriptorCountAllocateInfo
  in vkAllocateDescriptorSets
- Trace and rebuild Flags and VkDescriptorSetLayoutBindingFlagsCreateInfo
  in vkCreateDescriptorSetLayout
yalcinmelihyasin
yalcinmelihyasin approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@yalcinmelihyasin yalcinmelihyasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some minor comments otherwise it's fine

gapis/api/vulkan/api/bitfields.api Outdated Show resolved Hide resolved
gapis/api/vulkan/api/descriptor.api Outdated Show resolved Hide resolved
gapis/api/vulkan/api/descriptor.api Show resolved Hide resolved
pmuetschard
pmuetschard reviewed Aug 3, 2022
View reviewed changes
gapii/cc/vulkan_inlines.inc Outdated Show resolved Hide resolved
gapis/api/vulkan/api/vk12structs.api Outdated Show resolved Hide resolved
gapis/api/vulkan/errors.api Outdated Show resolved Hide resolved
@mikes-lunarg mikes-lunarg merged commit 5b0c2e3 into google:master Aug 8, 2022
@mikes-lunarg mikes-lunarg deleted the VK_EXT_descriptor_indexing branch August 8, 2022 23:11
rosasco-wk pushed a commit to rosasco-wk/agi that referenced this pull request Sep 3, 2022
@mikes-lunarg @rosasco-wk
Add VK_EXT_descriptor_indexing (google#1154)
379e2d1 
- Add extension types and enums
- Add props/features queries
- Trace and rebuild VkDescriptorSetVariableDescriptorCountAllocateInfo
  in vkAllocateDescriptorSets
- Trace and rebuild Flags and VkDescriptorSetLayoutBindingFlagsCreateInfo
  in vkCreateDescriptorSetLayout
@kocdemir kocdemir mentioned this pull request Sep 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuetschard pmuetschard pmuetschard left review comments

@yalcinmelihyasin yalcinmelihyasin yalcinmelihyasin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikes-lunarg @yalcinmelihyasin @pmuetschard