Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue 168 sense synset not passing wordnet object #170

Merged

Conversation

francis-dion
Copy link

Fixed issue 168 sense synset not passing wordnet object
Also added .idea/ (PyCharm IDE files) to .gitignore

Copy link
Owner

@goodmami goodmami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have some comments below, but I won't make you change the PR now.

.gitignore Show resolved Hide resolved
tests/relations_test.py Show resolved Hide resolved
wn/_core.py Show resolved Hide resolved
@goodmami goodmami merged commit 9d2b05a into goodmami:main Jun 12, 2022
@francis-dion francis-dion deleted the sense_synset_passing_wordnet_issue_168 branch June 12, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants