Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/text
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.18.0
Choose a base ref
...
head repository: golang/text
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.19.0
Choose a head ref
  • 3 commits
  • 10 files changed
  • 3 contributors

Commits on Sep 4, 2024

  1. all: fix printf(var) mistakes detected by latest printf checker

    The CodeWriter.WriteComment method is odd. It calls fmt.Sprintf
    on its arguments so the caller doesn't need to, but isn't named
    something like WriteCommentf as I'd expect. I tried renaming it,
    but it became a bigger change than I wanted. Leaving that for a
    future CL - this one just fixes clear mistakes to fix the build.
    
    For golang/go#69267.
    
    Change-Id: Ifba42d4512696194fbf21d6c8d3da76440b1ce9e
    Reviewed-on: https://go-review.googlesource.com/c/text/ /610676
    Reviewed-by: Tim King <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Auto-Submit: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    dmitshur authored and gopherbot committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    20097e4 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. all: fix some comments

    Change-Id: I6ba7a9de50acfa522d96609abead28d207ab4f81
    Reviewed-on: https://go-review.googlesource.com/c/text/ /611795
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Tim King <[email protected]>
    Auto-Submit: Tim King <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    cuishuang authored and gopherbot committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    38a95c2 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. x/text: Correct examples in number/doc

    Playground example: https://go.dev/play/p/9cuRyaNveO8
    
    Change-Id: I2fbc3fec0f3755eb3d11b47edfb2201d66fc622d
    Reviewed-on: https://go-review.googlesource.com/c/text/ /614395
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Auto-Submit: Ian Lance Taylor <[email protected]>
    Reviewed-by: Marcel van Lohuizen <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Reviewed-by: Carlos Amedee <[email protected]>
    dveeden authored and gopherbot committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    3043346 View commit details
    Browse the repository at this point in the history
Loading