Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/mod
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.14.0
Choose a base ref
...
head repository: golang/mod
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.17.0
Choose a head ref
  • 5 commits
  • 6 files changed
  • 5 contributors

Commits on Jan 26, 2024

  1. sumdb: replace globsMatchPath with module.MatchPrefixPatterns

    In CL 239797, src/cmd/go/internal/str.GlobsMatchPath was replicated as
    module.MatchPrefixPatterns. This redundancy eliminates the need for
    globsMatchPath. This CL replaces calls to globsMatchPath with
    module.MatchPrefixPatterns and removes the now redundant globsMatchPath.
    
    Change-Id: Idd6fc10e7cf24d7b9603fa17edb2460d50b2e4aa
    Reviewed-on: https://go-review.googlesource.com/c/mod/ /539815
    Auto-Submit: Bryan Mills <[email protected]>
    Reviewed-by: Cherry Mui <[email protected]>
    Reviewed-by: Bryan Mills <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    aofei authored and gopherbot committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    fa1ba42 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. modfile: use new go version string format in WorkFile.add error

    For golang/go#61888
    
    Tested: Ran go test ./modfile
    Change-Id: I254fe559f25ac643e842a935954d18744ae87b0b
    Reviewed-on: https://go-review.googlesource.com/c/mod/ /560875
    Reviewed-by: Bryan Mills <[email protected]>
    Run-TryBot: Sam Thanawalla <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    samthanawalla committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    766dc5d View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. modfile: fix crash on AddGoStmt in empty File

    AddGoStmt uses File.Syntax without checking whether
    it is nil or not. This causes crashes when using it on empty files that
    have not had their Syntax member initialized to a valid pointer.
    
    This change fixes it by ensuring File.Syntax is a valid pointer before
    proceeding.
    
    Fixes golang/go#62457.
    
    Change-Id: Iab02039f79e73d939ca5d3e48b29faa5e0a9a5ec
    Reviewed-on: https://go-review.googlesource.com/c/mod/ /570115
    Reviewed-by: Michael Knyszek <[email protected]>
    Auto-Submit: Bryan Mills <[email protected]>
    Reviewed-by: Bryan Mills <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    crazybolillo authored and gopherbot committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    18d3f56 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. sumdb/tlog: make NewTiles only generate strictly necessary tiles

    Currently, NewTiles returns tiles for every partial tree size from
    oldTreeSize to newTreeSize. However, if a log is only publishing
    checkpoints at oldTreeSize and newTreeSize, the trees of sizes
    oldTreeSize 1 to newTreeSize-1 are unverifiable, so those tiles are
    unnecessary. Also, NewTiles currently returns tiles that already exists
    as part of oldTreeSize, which are not new.
    
    This has a significant performance and cost difference when uploading
    tiles individually to e.g. object storage.
    
    Change-Id: I92a5d76bc54e7022991e51997e793356ab5e7d5c
    Reviewed-on: https://go-review.googlesource.com/c/mod/ /570295
    Auto-Submit: Filippo Valsorda <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Russ Cox <[email protected]>
    Reviewed-by: Cherry Mui <[email protected]>
    FiloSottile authored and gopherbot committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    87140ec View commit details
    Browse the repository at this point in the history
  2. modfile: do not collapse if there are unattached comments within blocks

    The existing implementation drops unattached comments
    when collapsing block into single line.
    
    Fixes #33280
    
    Change-Id: I388e1468657d461cba771e90d5e328746d927ae2
    Reviewed-on: https://go-review.googlesource.com/c/mod/ /541815
    Reviewed-by: Cherry Mui <[email protected]>
    Reviewed-by: Bryan Mills <[email protected]>
    Auto-Submit: Bryan Mills <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    quantonganh authored and gopherbot committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    aa51b25 View commit details
    Browse the repository at this point in the history
Loading