-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: CodeAction: unexpected JSON unmarshalling error in BundledLazyFixes (via telemetry) #68819
Comments
Given the analysis in #64503 (comment), and the fact the hypothesis (3) is no longer possible due to https://go.dev/cl/549575, hypothesis (1) seems likely: "a curious user or misbehaving client is sending home-made or invalid BundledFixes messages, or modifying the value before returning it to the server". The fact that the the LSP client string is "other" adds a small amount of evidentiary weight. We should probably downgrade the bug.Report to silently discard the message on the grounds that the client has meddled with it, or, better, report an ordinary error to be handled by the caller. |
This stack
pA-Ukg
was reported by telemetry:Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.
The text was updated successfully, but these errors were encountered: