Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding/xml: does not reject non-space before the root element or after the end of the root element #68332

Open
Tracked by #68293
DemiMarie opened this issue Jul 7, 2024 · 3 comments
Open
Tracked by #68293

encoding/xml: does not reject non-space before the root element or after the end of the root element #68332

DemiMarie opened this issue Jul 7, 2024 · 3 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@DemiMarie
Copy link
Contributor

Go version

1.22.5 (this is from pkg.go.dev)

Output of go env in your module/workspace:

Whatever is used on https://go.dev/play as of 2024-07-07

What did you do?

https://go.dev/play/p/SJIiUJ7VZW5

What did you see happen?

encoding/xml reports whitespace before and after the root element as xml.CharData, but this is wrong: the XML is ill-formed because XML entities are not allowed in these locations.

What did you expect to see?

An error indicating that the XML is ill-formed.
@DemiMarie DemiMarie mentioned this issue Jul 7, 2024
Open
14 tasks
@gabyhelp
Copy link

gabyhelp commented Jul 9, 2024

Related Issues and Documentation

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 9, 2024
@cagedmantis cagedmantis added this to the Backlog milestone Jul 9, 2024
@cagedmantis
Copy link
Contributor

cc @rsc

@cagedmantis
Copy link
Contributor

Addressed in proposal #68299

This was referenced Jul 11, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@cagedmantis @DemiMarie @gabyhelp