-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data race in hystrix client #137
Comments
As this is fixed, can we close this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We are facing the data race error using the latest code. After checking the history, you have recognized the same issue and proposed the fix in heimdall/pull/67. I have no idea why the fix hadn't been merged.
We can easily reproduce the error just by:
1, copy the unit test from test case to the latest code base.
2, run this test using "go test -race" several times
Note that, sometimes this is very easy to be reproduced (just run go test 3-5 rounds). But I also faced the case that I run about 20 rounds to get it reproduced.
Could you please help to evaluate the issue and provide a fix?
Thanks!
The text was updated successfully, but these errors were encountered: