Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[editorial] google_analytics.html: trim trailing whitespace from tpl actions #12505

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

chalin
Copy link
Contributor

@chalin chalin commented May 16, 2024

"Editorial" change only: from {{ ... }} to {{- ... }}, to trim template action trailing whitespace.

@jmooring
Copy link
Member

To be consistent with other embedded templates can we trim leading instead? For example:
https://github.com/gohugoio/hugo/blob/master/tpl/tplimpl/embedded/templates/schema.html

@chalin
Copy link
Contributor Author

chalin commented May 16, 2024

Sure whatever convention you prefer.

@jmooring
Copy link
Member

Trim leading please... thanks.

@chalin
Copy link
Contributor Author

chalin commented May 16, 2024

Ok, done ✨

@bep bep requested a review from jmooring August 29, 2024 19:28
Copy link
Member

@jmooring jmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bep bep merged commit 53a8de2 into gohugoio:master Aug 29, 2024
1 check passed
@chalin chalin deleted the patch-1 branch August 29, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants