Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR #4/5 Astolfo feature/builtin-quaternion #68

Merged
merged 2 commits into from
Feb 12, 2023
Merged

PR #4/5 Astolfo feature/builtin-quaternion #68

merged 2 commits into from
Feb 12, 2023

Conversation

RealAstolfo
Copy link
Contributor

Co-Authored-By: Thomas ten Cate [email protected]

Implemented Quaternion to the best of my current ability to resemble godot's, meant to be merged after #67

@Bromeon Bromeon added feature Adds functionality to the library c: core Core components labels Jan 16, 2023
@ttencate
Copy link
Contributor

If #71 goes through, we could split out some reusable macros to implement operators that work component-wise. Add and Sub work per component for a quat, but Mul does not. And similarly for quat-and-scalar operations.

Bromeon
Bromeon reviewed Jan 21, 2023
View reviewed changes
Copy link
Member

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you for this initial quaternion implementation!

Maybe a general question, did you have any chance to test some of the functionality?

bors try

godot-core/src/builtin/quaternion.rs Outdated Show resolved Hide resolved
godot-core/src/builtin/quaternion.rs Outdated Show resolved Hide resolved
godot-core/src/builtin/quaternion.rs Outdated Show resolved Hide resolved
godot-core/src/builtin/others.rs Outdated Show resolved Hide resolved
bors bot added a commit that referenced this pull request Jan 21, 2023
@bors
Try #68:
e0d92e4
@bors
Copy link
Contributor

bors bot commented Jan 21, 2023

try

Build failed:

@ttencate
Copy link
Contributor

ttencate commented Jan 22, 2023 •
edited
Loading

Maybe a general question, did you have any chance to test some of the functionality?

About that... it would be great if we had autogenerated functions that call into the engine, so we can write succinct tests that compare the results to official ones without having to hardcode them. Plus, we could call into them for the less trivial implementations, instead of rebuilding them from scratch.

@Bromeon
Copy link
Member

Bromeon commented Feb 1, 2023

Whenever you find some time, could you rebase this onto master and address the comments? Thank you! 🙂

@RealAstolfo RealAstolfo force-pushed the astolfo-feature/builtin-quaternion branch from 1bc92aa to cba1d9d Compare February 5, 2023 02:59
Bromeon
Bromeon reviewed Feb 5, 2023
View reviewed changes
Copy link
Member

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the update!
Some smaller remarks left 🙂

bors try

godot-core/src/builtin/quaternion.rs Show resolved Hide resolved
godot-core/src/builtin/quaternion.rs Outdated Show resolved Hide resolved
godot-core/src/builtin/quaternion.rs Outdated Show resolved Hide resolved
godot-core/src/builtin/quaternion.rs Show resolved Hide resolved
godot-core/src/builtin/quaternion.rs Show resolved Hide resolved
godot-core/src/builtin/quaternion.rs Outdated Show resolved Hide resolved
godot-core/src/builtin/quaternion.rs Outdated Show resolved Hide resolved
bors bot added a commit that referenced this pull request Feb 5, 2023
@bors
Try #68:
56b2c9d
@bors
Copy link
Contributor

bors bot commented Feb 5, 2023

try

Build succeeded:

@RealAstolfo RealAstolfo force-pushed the astolfo-feature/builtin-quaternion branch from cba1d9d to 000d056 Compare February 11, 2023 23:23
@Bromeon Bromeon force-pushed the astolfo-feature/builtin-quaternion branch from 2fa0d86 to 4f3d106 Compare February 12, 2023 08:39
@Bromeon
Copy link
Member

Bromeon commented Feb 12, 2023

bors r

@bors
Copy link
Contributor

bors bot commented Feb 12, 2023

Build succeeded:

@bors bors bot merged commit cb3632e into godot-rust:master Feb 12, 2023
@Bromeon Bromeon mentioned this pull request Mar 6, 2023
Open
@lilizoey lilizoey mentioned this pull request Jun 14, 2023
Open
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bromeon Bromeon Bromeon left review comments

Assignees
No one assigned
Labels
c: core Core components feature Adds functionality to the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RealAstolfo @ttencate @Bromeon