Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(remote): TASK_REMOTE_DIR does not work when absolute #1715

Merged
merged 2 commits into from
Aug 25, 2024
Merged

fix(remote): TASK_REMOTE_DIR does not work when absolute #1715

merged 2 commits into from
Aug 25, 2024

Conversation

vmaerten
Copy link
Member

@vmaerten vmaerten commented Jul 8, 2024

Two issues :

  • we checked for TASK_TEMP_DIR but it should be TASK_REMOTE_DIR
  • the expand was not correct

@vmaerten vmaerten added area: remote Changes related to remote taskfiles. type: bug Something not working as intended. labels Aug 13, 2024
@vmaerten vmaerten merged commit c243b0e into go-task:main Aug 25, 2024
14 checks passed
@vmaerten vmaerten deleted the fix/absolute_task_remote_dir branch August 25, 2024 21:03
vmaerten added a commit that referenced this pull request Aug 25, 2024
@vmaerten
chore: changelog for #1715
f302b50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreynering andreynering andreynering approved these changes

@pd93 pd93 Awaiting requested review from pd93

Assignees
No one assigned
Labels
area: remote Changes related to remote taskfiles. type: bug Something not working as intended.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmaerten @andreynering