feat(remote): support include git remote #1652
Conversation
|
I've tested it and a friend also tested it. I am open to gather feedback on it :) |
|
@vmaerten Thanks for working on this! This is a very popular request. I will definitely give this a go in the next couple of days. Finally some nice weather in the UK, so I'll be out enjoying the sun as much as possible this weekend! 🌞 It might be worth putting a message on the remote experiment issue so that people who are subscribed over there can try it too. I have updated the OP there to link back here. |
|
I really enjoy working on Task. Let me know if you have questions regarding my implementation Good idea! I've just done it 🙂 |
|
@blackjid 's comment :
First of all, thanks for the feedback. Following your propostions, I like the one with the query param representing the filename. In the other hand, if the community already knows the "terraform" format, it could be good to adopt it. Let's discuss with @pd93 and @andreynering |
|
Hi, I find this work awesome ! Just wanted to mention that I've been able to run this on my side using http over public repo, private repo using token auth and ssh. All behaved as expected. This, added to the remote file feature will definitely help saving a tremendous amount of time sharing and managing taskfiles. I'm really excited to have this available in a few. Thanks for this work. |
|
Thanks for checking this! |
|
Any update ? |
There was a problem hiding this comment.
Generally pretty happy with this. Just one minor comment.
w.r.t @blackjid's comment:
There have been a lot of comments in the past about reusing the go-getter syntax as it seems pretty popular in the Go community. We're not using go-getter right now, but using a compatible syntax would make it easier to transition to it in the future if we wanted to for any reason.
|
I need to rebase due to recent merged PR |
taskfile/node_git_test.go
Outdated
| } | ||
|
|
||
| func TestGitNode_sshWithDir(t *testing.T) { | ||
| node, err := NewGitNode("[email protected]:foo/bar.git?ref=main//directory/Taskfile.yml", "", false) |
There was a problem hiding this comment.
but using a compatible syntax would make it easier to transition to it in the future if we wanted to for any reason.
I did't thought about it, that would be a compelling reason to use that syntax.
I don't think this new change syntax is compatible...
[email protected]:foo/bar.git?ref=main//directory/Taskfile.yml
should be
[email protected]:foo/bar.git//directory/Taskfile.yml?ref=main
so ref is directly mapped to a git refeference, could be a branch or a tag for example.
id's say you'd need to split the url in // to get the git url at 0 and the filename at 1
There was a problem hiding this comment.
hey @vmaerten thanks for all the work on this!
just want to add that with this syntax, the ref query string should be optional, because, it will only reference to a branch or tag, and without it it would be the default branch.
There was a problem hiding this comment.
Hey!
You're right! I'll work on this :)
|
What am I doing wrong? $ export TASK_X_REMOTE_TASKFILES=1
$ task --list --taskfile [email protected]/$ORGANIZATION/$REPO?ref=main//taskfile.yml
stat [email protected]/$ORGANIZATION/$REPO?ref=main//taskfile.yml: no such file or directoryThe following code shows that the org, repo, and file exists ... $ git clone [email protected]:$ORGANIZATION/$REPO.git --branch main && cp $REPO/taskfile.yml . |
|
EDIT: like you use the URL for git clone : |
|
@blackjid & @pd93 Following this comment : #1652 (comment) |
I've work on add the support of Git in the remote experimentation.
I've used the go-git package, which is Git implementation in pure go.
I've also used git-urls to help me to parse all URLs.
Some informations :
I'll work next on perf optimisation. I've in mind to mutualise git clone to avoid cloning multiple times the same repo.
I've added tests. I'll add test of node_http in another PR.
EDIT : The link with to the preview