Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Support for multiple return values from go function to python #282

Draft
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

nishantsharma
Copy link

Support for multiple return values from go function to python

@nishantsharma
Copy link
Author

Some memory leaks exist.

@rcoreilly
Copy link
Member

Yeah, would it make sense to delete this PR for the time being and rebase on the variadic version which I will test now. The variadic one does not have any leaks?

@rcoreilly
Copy link
Member

rcoreilly commented Jun 19, 2022

you can resubmit a PR once you have it working with out leaks I mean.

@nishantsharma
Copy link
Author

Sure. Variadic shouldn't have leaks. I may take up fixing of memory leaks later as per internal priority.

@nishantsharma
Copy link
Author

Actually, it may still make sense to review from the perspective of behavior. Esp. translating error return into exceptions. Also, deleting PRs causes context to be lost. Will suggest making it a draft PR.

@nishantsharma nishantsharma marked this pull request as draft June 19, 2022 08:22
@rcoreilly
Copy link
Member

rcoreilly commented Jun 19, 2022

ok.. I'll try to take a look in a few days. Meanwhile in the future, please run your code through gofmt -- that check is failing on test.

@rcoreilly
Copy link
Member

ps. thanks for submitting these fixes -- much appreciated!

@nishantsharma nishantsharma force-pushed the nisshar/MultipleReturns branch 2 times, most recently from d1091c5 to 9167efa Compare June 20, 2022 10:36
@nishantsharma
Copy link
Author

URL changes are temporary. Made them to test. Will revert before switching PR draft status. JFYI.

@nishantsharma nishantsharma changed the title Support for multiple return values from go function to python [Draft] Support for multiple return values from go function to python Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants