Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary lock operation for reading from cache in extractStructCache method - fixed double checknig/reading cStruct in validateStruct method #1236

Closed
wants to merge 2 commits into from
Closed

Unnecessary lock operation for reading from cache in extractStructCache method - fixed double checknig/reading cStruct in validateStruct method #1236

wants to merge 2 commits into from

Conversation

amirkaramiit
Copy link

Fixes Or Enhances

  • Fixed unnecessary Lock, and UnLock Operations in *Validate.extractStructCache method while the struct (cStruct) has been cached.
  • Fixed double-checking structCache for a Cached struct in *validate.validateStruct method, while it was done in *Validate.extractStructCache method.

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@amirkaramiit amirkaramiit requested a review from a team as a code owner February 22, 2024 22:38
@coveralls
Copy link

Coverage Status

coverage: 74.167% (-0.005%) from 74.172%
when pulling e83b403 on amirkaramiit:validator-extractCStruct-get-duplicate
into b328f72 on go-playground:master.

@amirkaramiit amirkaramiit closed this by deleting the head repository Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amirkaramiit @coveralls